Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

refactor: remove authentication from Search fragment

Description

As search suggestions and search results are now using WebSearchHelper from GPlayAPI, these requests don't need to tie with authentication.

Search Fragment now extends from Android Fragment instead of TimeoutFragment to exclude authentication functionalities.

What doesn't work yet ⚠️

  • Changing source (Common apps, Open-Source or PWA) in the Settings screen doesn't reflect on the search results. It'll be fixed when the data loading gets refactored.

This is the first MR of the refactoring tasks.

Screenshots

Technical details

Tests

Issues

e/os/backlog#3537

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Edited by Fahim M. Choudhury

Merge request reports

Loading