Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Draft: feat: show size for open-source apps

Fahim M. Choudhury requested to merge 3563-get-size-of-open-source-apps into main

Description

CleanAPK API response contains APK info in a dynamic property named "update_<X>" where X is any integer.

ApplicationDeserializer is modified to parse the property "apk_file_size" from the property "update_<X>". The value contains a string such as 4.05 KiB, 1.23 MiB, etc.

To make the size info consistent with existing UI for Google Play, which shows the size in KB and MB instead of KiB and MiB, size conversion is implemented in BinaryToDecimalSizeConverter, including unit tests.

If there's no correct size information, the app details UI will not show any info (See the bottom right image).

Screenshots

Screenshot_20250513_134316.png Screenshot_20250513_134409.png
Screenshot_20250513_134503.png Screenshot_20250513_140824.png

Technical details

Tests

Issues

e/backlog#6455

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Fahim M. Choudhury

Merge request reports

Loading