Refacto 2025

Description

• Introduce Stores class which is the class we are mainly going to update to add a new Store backend
• Get rid off a bunch of conditions and start looping on available Stores instead
• Remove Origin class which was redundant with the Source class
• Sanitize the StoreRepository interface

Screenshots

Technical details

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2903

10 commandments of code reviews

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

• New Features

  • Introduced a new Stores class for managing store repositories.
  • Updated getHomeScreenData methods across multiple repositories to accept a list of Home objects and return a list of Home instead of a map.

• Bug Fixes

  • Enhanced error handling in the getHomeScreenData method of PlayStoreRepository.

• Refactor

  • Simplified data retrieval logic in HomeApiImpl and related classes by removing unnecessary parameters and methods.
  • Transitioned several methods in ApplicationDataManager and related classes from asynchronous to synchronous execution.

• Tests

  • Expanded test coverage for AppsApi functionality.
  • Removed the HomeApiTest class, indicating a shift in testing strategy.
  • Updated dependency management in tests related to ApplicationDataManager.