Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Sanitize StoreRepository interface and the classes implementing it

Jonathan Klee requested to merge 0000-u-improvements-jklee-2 into 0000-u-refacto

Description

Sanitize StoreRepository interface and the classes implementing it

Before:

interface StoreRepository {
    suspend fun getHomeScreenData(): Any
    suspend fun getAppDetails(packageNameOrId: String): Any?
}

After:

interface StoreRepository {
    suspend fun getHomeScreenData(): Map<String, List<Application>>
    suspend fun getAppDetails(packageNameOrId: String): Application
}

Screenshots

Technical details

Tests

Issues

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced data retrieval with updated return types for home screen data and application details, improving type safety and clarity.
    • Introduced HomeConverter class for converting CleanApkHome to Home objects.
  • Bug Fixes

    • Removed deprecated references to Progressive Web Apps (PWAs) across multiple languages.
  • Documentation

    • Updated internal documentation to reflect changes in method signatures and data models.
  • Tests

    • Updated test cases to align with new data types and ensure consistency in application behavior.
Edited by Jonathan Klee

Merge request reports

Loading