Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

App Lounge: Change minimum sdk to target API 26

Vincent Bourgmayer requested to merge 2696-update-minSDK into main

Description

App lounge used Android API 25 as minimum SDK which makes compatibility issues with stuff from Java 1.8 which is only available on api 26 (like Instant). Supporting this API has no sense since we don't support any device of this android version anymore, and API 25 was released around 2016 according to Jonathan.

Technical details

It is a requirement for current implementation of fix for https://gitlab.e.foundation/e/os/backlog/-/issues/2696+

What does it changes ?

  • Java 1.8 feature is available
  • Removed all the check for if "BUILD.SDK was below ANDROID O
  • Removed old launcher icon for xxdpi folder has it was used for android API below Android O.
  • only keep adaptative icon mipmap-anydpi folder with the xml icon.

according to src1 & src2

Tests

Installed APK on community build and open app lounge, make some research, check every tabs. It works

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2696+'s subtask: https://gitlab.e.foundation/e/os/backlog/-/work_items/2744+

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features

    • Updated minimum Android API level to 26, enhancing compatibility with newer devices.
  • Bug Fixes

    • Simplified notification channel creation logic by removing unnecessary version checks, improving reliability across Android versions.
  • Chores

    • Removed outdated application launcher icons for various screen densities, streamlining resource management.
Edited by Vincent Bourgmayer

Merge request reports

Loading