Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

refactor: modify dummy search behaviour

Fahim Masud Choudhury requested to merge 2235-bug-unavailable-app-on-token-refresh into main

Description

While searching for an app in App Lounge, initially we'll be using a dummy search for Facebook in the background in parallel with the original search to probe Google Play. We will expect both Facebook and Messenger apps to be returned in the search results. If it doesn't happen, then we'll refresh the token and try to search again.

Besides, if the token used in App Lounge gets refreshed in the process (or in any other scenario), we'll show a Toast to the user in debug builds.

Finally, HTTP logging level is set to request and headers only to avoid overflowing Logcat.

Tests

Manual search from App Lounge has been performed to test the behaviour of the changes.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/2235

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features
    • Introduced a new dummy search functionality to enhance search result handling.
  • Improvements
    • Enhanced logging for search results to include contextual query information.
    • Adjusted logging level for network requests to improve performance and clarity during debugging.
  • Bug Fixes
    • Streamlined search handling process for better user experience when search results are insufficient.
Edited by Fahim Masud Choudhury

Merge request reports