Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

feat(updates): add version name comparison for update checks (#2509)

Sayantan Roychowdhury requested to merge 2509-allow_versionName_comparison into main

Description

Allow version name comparison while checking for updates

Screenshots

Technical details

Instead of increasing versionCodes for our forks, we now update the versionNames. This MR adds support for string comparison in versionNames to be used for checking updates.

Examples:
4.3.9-ose+20240725
4.3.9-ose+20240828

Tests

Issues

https://gitlab.e.foundation/e/backlog/-/issues/2509

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Summary by CodeRabbit

  • New Features

    • Enhanced package management functionality to include version name in version comparisons, improving the app update process.
    • Updated methods now support additional parameters for better application status retrieval.
  • Bug Fixes

    • Improved accuracy in determining if an application is updatable by incorporating version name checks.
  • Tests

    • Added a comprehensive suite of unit tests for the package manager to ensure robust functionality and reliability.
    • Updated existing tests to align with new method signatures, ensuring compatibility with recent changes.
Edited by CodeRabbitAI

Merge request reports

Loading