Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

refactor: improve code organization for OkHttp interceptors, Retrofit APIs and Hilt modules

Fahim Masud Choudhury requested to merge 000-separate-hilt-modules into main

Description

  • InterceptorModule and NetworkModule are introduced to contain the relevant functionality.
  • RetrofitModule is renamed to RetrofitApiModule to contain only the APIs needed for Retrofit.
  • /data/ageRating directory is renamed to /data/parentalcontrol.

Screenshots

Technical details

This MR includes the addition of a network module and updates to the retrofit module. The newly added network module includes the configuration for OkHttpClient and different deserializers. Some of the deserializers added include Moshi, Gson, and JacksonConverterFactory for YAML files.

In addition to this, the retrofit module has been updated to include different APIs such as CleanApkRetrofit, CleanApkAppDetailsRetrofit, ExodusTrackerApi, FdroidApiInterface, EcloudApiInterface, AgeGroupApi, and FDroidMonitorApi.

Furthermore, there are also some changes in the directory structure of the codebase. The ageRating package has been renamed to parentalcontrol, and the RetrofitModule has been moved to the network package.

Lastly, the commit includes the addition of the okhttp3 logging interceptor in the build.gradle file.

Tests

Issues

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Fahim Masud Choudhury

Merge request reports