Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

1798 fix crash

Description

This MR handles some scenarios related to this exception (ArrayIndexOutOfBound).

This MR also handled some exceptions. Crash 1, Crash 2 and some redundant exception handling are removed from Retrofit related usage.

Screenshots

Technical details

This exception (ArrayIndexOutOfBound) is already handled with try/catch, So app doesn't face any crash because of this. Here, If the download status of any download is Unknown status (-1) for any reason, installation is canceled.

We have found some unhandled exceptions Crash 1, Crash 2, When we were investigating the mentioned ArrayIndexOutOfBound exception. Those unhandled exceptions are handled.

Exception handling is removed from RetrofitModule, which is redundant, As now we have NetworkHandler where we handle any type of network error.

Tests

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/1798

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Hasib Prince

Merge request reports

Loading