Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fixed: overriding currentHomes

Hasib Prince requested to merge 228-homepage_issue into main

Description

This MR fix a regression of homepage refactoring.

Screenshots

Technical details

HomeViewModel maintains state of homepage data with a list (currentHomes: List). This list is updated when any new data is fetched. And Homeresult.data comes from data layer which is a mutable list that can be changed anytime. That's why we're setting a copy of the list to currentHomes, so that currentHomes isn't changed when homeresult.data is changed.

Tests

Issues

apps/-/issues/228

10 commandments of code reviews

👪 ❤ https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Closes #228

Merge request reports