Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fixed: duplicate item in search page

Hasib Prince requested to merge 1549-search_duplicate_item into main

Description

Fixed duplicate item in search page when user search any app by package name.
Removed the bottom progressbar from search page as now we show a circular progress at the bottom of the list of search page.

Screenshots

device-2023-08-28-171530

Technical details

Duplicate item appeared because same item came in search result twice from two apis. One for fetching the app with package name and another one is for fetching search result with the keyword. Now we fixed it by sharing a distinct list using .distinctBy{ it.packageName}.

Tests

Scenario: Users search app from search page
  Given User is on the search page
  And Internet is available
  When user search any app with package name
  Then App should show a search result with that particular app of search package name
  And Other results related to that package name

Issues

backlog/-/issues/1549

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading