Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

1549 loading search page

Hasib Prince requested to merge 1549-loading_search_page into main

Description

Updated the way of fetching data for search result of gplay apps. Now pagination is added which works with user's scroll. And updated the strategy of handling timeout.

Screenshots

device-2023-08-22-112726

Technical details

Previously, Gplay search data was loaded within a loop. That means, the all data are fetched in a while loop which runs until all pages of data are fetched. Now, Gplay search result of next page is fetched when user scrolls to the bottom of the page. It helps to reduce unnecessary api calls.

For checking timeout, Previously it was checked with timer. Now it's handled by OkHttpClient.

Tests

Issues

backlog/-/issues/1549

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Hasib Prince

Merge request reports

Loading