Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fixed: hang on opening of updatepage

Hasib Prince requested to merge 7003-hang_update_page into main

Description

Fixed the hang when user navigates to update page. When Update page is opened, it does some intensive operation which blocks the UI thread.

Screenshots

device-2023-06-21-192147

Technical details

Initial operation for update page is triggered in a coroutine launched by viewModelScope which uses Dispatchers.Main. Update page do some operation related to PackageManager which is very intensive operation. These operations were done within viewModelScope which blocks the UI thread. Now this operations are invoked in Dispatchers.IO which makes free the UI thread.

Tests

Launch App Lounge, go to update page and observe any hang exists or not.

Issues

backlog/-/issues/7003

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Merge request reports

Loading