Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

fixed: showing signature mismatch dialog

Hasib Prince requested to merge 333-fix_coroutine_blocker into main

Description

Fixed showing the dialog of signature mismatch error.

It's regression isssue when we optimized the homepage loading time of app lounge where We skipped auth validation for every launch as optimization.

Screenshots

Screenshot_from_2023-06-16_17-44-05

Technical details

App collects error events through flow api of kotlin. Now We collect data from multiple flow in a single coroutine. Here one flow is for Auth error and another flow is for Signature missmatch error. Here flow of auth error is blocking the flow of Signature mismatch error as flow is thread blocker. That's why Error for signature mismatch is not shown.

To resolve this issue, We have collected data from flows by launching separate coroutines.

Tests

Issues

backlog/-/issues/1363

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Merge request reports

Loading