Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Issue 788: Fix category display in app details page

Sayantan Roychowdhury requested to merge 788-fix_category_display into release-1.5-rc3

Description

App details page does not show category properly. This fixes that.

Screenshots

Technical details

GPlay API when fetching details of single app does not pass the category information. But this is present

  1. when the app is showed in Home, Search.
  2. For Categories, we are again not getting the category text directly, so we are passing the text initially shown to the user (when selecting a category to show apps from).
  3. For Updates, we have no way to get the category, so we are hiding it.

Just another day of bypassing GPlay API inconsistencies 😄

Tests

Open apps from various tabs and see if the category is being displayed.

Issues

https://gitlab.e.foundation/e/os/backlog/-/issues/788

10 commandments of code reviews

<Keep the link above in the merge request description to remind the 10 commandments to the reviewers.>

👪 ❤️ https://gitlab.e.foundation/internal/wiki/-/wikis/development/code-review

Edited by Sayantan Roychowdhury

Merge request reports

Loading