Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee69e4bf authored by Jonathan Klee's avatar Jonathan Klee
Browse files

Catch the exception inside the coroutine scope 

Sentry reported some uncaught GPlayLoginException exceptions
probably because of exception propagation.

Let's catch the exception inside the coroutine scope now to be sure
the exception is caught.
parent 0617481c

app/src/main/java/foundation/e/apps/install/splitinstall/SplitInstallBinder.kt

+5 −5
Original line number Diff line number Diff line
@@ -68,8 +68,8 @@ class SplitInstallBinder( 
    }



    override fun installSplitModule(packageName: String, moduleName: String) {

        try {

        coroutineScope.launch {

            try {

                authenticatorRepository.getValidatedAuthData()

                if (authenticatorRepository.gplayAuth == null) {

                    Timber.w(AUTH_DATA_ERROR_MESSAGE)
@@ -77,12 +77,12 @@ class SplitInstallBinder( 
                    return@launch

                }

                downloadModule(packageName, moduleName)

            }

            } catch (exception: GPlayLoginException) {

                Timber.w("$AUTH_DATA_ERROR_MESSAGE $exception")

                handleError(packageName)

            }

        }

    }



    private fun handleError(packageName: String) {

        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {