refactor: apply Jonathan's suggestion (d002ca4c) · Commits · e / os / App Lounge

app/src/main/java/foundation/e/apps/data/gitlab/SystemAppsUpdatesRepository.kt

+9 −8

Original line number	Diff line number	Diff line
		@@ -113,7 +113,7 @@ class SystemAppsUpdatesRepository @Inject constructor(
		): String? {
		val projectId = systemAppProject.projectId
		val releaseResponse = releaseInfoApi.getReleases(projectId)
		val releases = releaseResponse.body()?.toMutableList()
		var releases = releaseResponse.body()

		if (!releaseResponse.isSuccessful \|\| releases == null) {
		Timber.e("Failed to fetch releases for project id - $projectId")
		@@ -121,15 +121,11 @@ class SystemAppsUpdatesRepository @Inject constructor(
		}

		if (systemAppProject.dependsOnAndroidVersion) {
		//expects something like: vx.y.z-T for android T
		releases.removeIf {
		!it.tagName.endsWith(
		suffix = "-$androidVersionCode",
		ignoreCase = true
		)
		}
		val versionSuffix = "-$androidVersionCode"
		releases = releases.filter { isVersionedTag(it.tagName, versionSuffix) }
		}


		val sortedReleases = releases.sortedByDescending {
		it.releasedAt
		}
		@@ -143,6 +139,11 @@ class SystemAppsUpdatesRepository @Inject constructor(
		return null
		}

		private fun isVersionedTag(tag: String, versionSuffix: String): Boolean {
		return tag.endsWith(suffix = versionSuffix, ignoreCase = true)
		}


		private suspend fun getApplication(
		packageName: String,
		releaseType: OsReleaseType,