Fix bug which caused progress bar to run forever

app/src/main/java/io/eelo/appinstaller/updates/model/OutdatedApplicationsFileReader.kt

@@ -25,27 +25,29 @@ class OutdatedApplicationsFileReader(private val applicationManager: Application
                     totalLines++
                 }
             }
-            context[0].openFileInput(Constants.OUTDATED_APPLICATIONS_FILENAME).use {
-                BufferedReader(InputStreamReader(it)).forEachLine { packageName ->
-                    Execute({
-                        val application = applicationManager.findOrCreateApp(packageName)
-                        val error = application.assertBasicData(context[0])
-                        if (error == null) {
-                            if (application.state == State.NOT_UPDATED) {
-                                applications.add(application)
+            if (totalLines > 0) {
+                context[0].openFileInput(Constants.OUTDATED_APPLICATIONS_FILENAME).use {
+                    BufferedReader(InputStreamReader(it)).forEachLine { packageName ->
+                        Execute({
+                            val application = applicationManager.findOrCreateApp(packageName)
+                            val error = application.assertBasicData(context[0])
+                            if (error == null) {
+                                if (application.state == State.NOT_UPDATED) {
+                                    applications.add(application)
+                                }
                             }
-                        }
-                    }, {
-                        requestsComplete++
-                        if (requestsComplete == totalLines) {
-                            synchronized(blocker) {
-                                blocker.notify()
+                        }, {
+                            requestsComplete++
+                            if (requestsComplete == totalLines) {
+                                synchronized(blocker) {
+                                    blocker.notify()
+                                }
                             }
-                        }
-                    })
-                }
-                synchronized(blocker) {
-                    blocker.wait()
+                        })
+                    }
+                    synchronized(blocker) {
+                        blocker.wait()
+                    }
                 }
             }
         } catch (exception: Exception) {

app/src/main/java/io/eelo/appinstaller/updates/model/UpdatesWorker.kt

@@ -29,12 +29,14 @@ class UpdatesWorker(context: Context, params: WorkerParameters) : Worker(context
     }
 
     override fun onApplicationsFound(applications: ArrayList<Application>) {
-        applicationContext.openFileOutput(Constants.OUTDATED_APPLICATIONS_FILENAME,
-                Context.MODE_PRIVATE).use {
-            applications.forEach { application ->
-                it.write((application.basicData!!.packageName + "\n").toByteArray())
+        if (applications.size > 0) {
+            applicationContext.openFileOutput(Constants.OUTDATED_APPLICATIONS_FILENAME,
+                    Context.MODE_PRIVATE).use {
+                applications.forEach { application ->
+                    it.write((application.basicData!!.packageName + "\n").toByteArray())
+                }
+                it.close()
             }
-            it.close()
         }
         synchronized(blocker) {
             blocker.notify()