chore:3871: Fix detekt. (52b02786) · Commits · e / os / App Lounge

app/detekt-baseline.xml

+1 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@
		<ID>LongParameterList:ApplicationListRVAdapter.kt$ApplicationListRVAdapter$( private val applicationInstaller: ApplicationInstaller, private val privacyInfoViewModel: PrivacyInfoViewModel, private val appInfoFetchViewModel: AppInfoFetchViewModel, private val mainActivityViewModel: MainActivityViewModel, private val currentDestinationId: Int, private var lifecycleOwner: LifecycleOwner?, private var paidAppHandler: ((Application) -> Unit)? = null )</ID>
		<ID>LongParameterList:CleanApkRetrofit.kt$CleanApkRetrofit$( @Query("keyword") keyword: String, @Query("source") source: String = APP_SOURCE_FOSS, @Query("type") type: String = APP_TYPE_ANY, @Query("nres") nres: Int = 20, @Query("page") page: Int = 1, @Query("by") by: String? = null, )</ID>
		<ID>LongParameterList:EglExtensionProvider.kt$EglExtensionProvider$( egl10: EGL10, eglDisplay: EGLDisplay, eglConfig: EGLConfig?, ai: IntArray, ai1: IntArray?, set: MutableSet<String> )</ID>
		<ID>LongParameterList:MainActivityViewModel.kt$MainActivityViewModel$( private val appLoungeDataStore: AppLoungeDataStore, private val applicationRepository: ApplicationRepository, private val appManagerWrapper: AppManagerWrapper, private val appLoungePackageManager: AppLoungePackageManager, private val pwaManager: PwaManager, private val ecloudRepository: EcloudRepository, private val blockedAppRepository: BlockedAppRepository, private val gPlayContentRatingRepository: GPlayContentRatingRepository, private val fDroidAntiFeatureRepository: FDroidAntiFeatureRepository, private val appInstallProcessor: AppInstallProcessor, private val systemAppsUpdatesRepository: SystemAppsUpdatesRepository, )</ID>
		<ID>LongParameterList:MainActivityViewModel.kt$MainActivityViewModel$( private val appLoungeDataStore: AppLoungeDataStore, private val applicationRepository: ApplicationRepository, private val appManagerWrapper: AppManagerWrapper, private val appLoungePackageManager: AppLoungePackageManager, private val pwaManager: PwaManager, private val blockedAppRepository: BlockedAppRepository, private val gPlayContentRatingRepository: GPlayContentRatingRepository, private val fDroidAntiFeatureRepository: FDroidAntiFeatureRepository, private val appInstallProcessor: AppInstallProcessor, private val systemAppsUpdatesRepository: SystemAppsUpdatesRepository, )</ID>
		<ID>LongParameterList:UpdatesManagerImpl.kt$UpdatesManagerImpl$( @ApplicationContext private val context: Context, private val appLoungePackageManager: AppLoungePackageManager, private val applicationRepository: ApplicationRepository, private val faultyAppRepository: FaultyAppRepository, private val appLoungePreference: AppLoungePreference, private val fDroidRepository: FDroidRepository, private val blockedAppRepository: BlockedAppRepository, private val systemAppsUpdatesRepository: SystemAppsUpdatesRepository, )</ID>
		<ID>LongParameterList:UpdatesWorker.kt$UpdatesWorker$( @Assisted private val context: Context, @Assisted private val params: WorkerParameters, private val updatesManagerRepository: UpdatesManagerRepository, private val appLoungeDataStore: AppLoungeDataStore, private val authenticatorRepository: AuthenticatorRepository, private val appInstallProcessor: AppInstallProcessor, private val blockedAppRepository: BlockedAppRepository, private val systemAppsUpdatesRepository: SystemAppsUpdatesRepository, )</ID>
		<ID>MagicNumber:AnonymousLoginManager.kt$AnonymousLoginManager$200</ID>

app/src/main/java/foundation/e/apps/data/playstore/PlayStoreRepository.kt

+9 −11

Original line number	Diff line number	Diff line
		@@ -283,14 +283,6 @@ class PlayStoreRepository @Inject constructor(
		appDetails.toApplication(context)
		}

		private suspend fun getAppDetailsHelper(): AppDetailsHelper {
		return doAuthenticatedRequest { authData ->
		val appDetailsHelper = AppDetailsHelper(authData).using(gPlayHttpClient)

		appDetailsHelper
		}
		}

		private suspend fun refreshPlayStoreAuthentication() {
		Timber.i("Refreshing authentication.")
		updateToken()
		@@ -423,6 +415,8 @@ class PlayStoreRepository @Inject constructor(
		}
		}

		// Prepared for next refactoring task.
		@Suppress("UnusedPrivateMember")
		private suspend fun <T> doAuthenticatedRequestAutoRefreshToken(request: suspend (AuthData) -> T): T {
		return exponentialBackoffRetry(
		initialDelay = 100.milliseconds,
		@@ -434,12 +428,15 @@ class PlayStoreRepository @Inject constructor(
		if (exception is HttpUnauthorizedException) {
		_faultyEmail.emit(appLoungeDataStore.getAuthData().email)
		true
		} else false
		} else {
		false
		}
		},
		doBeforeRetry = { refreshPlayStoreAuthentication() }
		)
		}

		@Suppress("ThrowsCount", "TooGenericExceptionCaught")
		private suspend fun <T> gPlayRequestWithUnswallowedException(request: suspend () -> T): T {
		val lastErrorFlow = gPlayHttpClient.requestException.shareIn(
		scope = ioCoroutineScope,
		@@ -447,6 +444,7 @@ class PlayStoreRepository @Inject constructor(
		replay = 1
		)

		@Suppress("TooGenericExceptionCaught")
		return try {
		request()
		} catch (e: Exception) {

app/src/main/java/foundation/e/apps/data/playstore/utils/GPlayHttpClient.kt

+13 −6

Original line number	Diff line number	Diff line
		@@ -210,9 +210,16 @@ class GPlayHttpClient @Inject constructor(

		// Swallow the exception, until upper layer are upgraded.
		throw when (parsedException) {
		is HttpFailedCodeException -> GplayHttpRequestException(parsedException.statusCode, parsedException.message?: "HttpFailed exception ${parsedException.statusCode}")
		is HttpFailedCodeException ->
		GplayHttpRequestException(
		parsedException.statusCode,
		parsedException.message ?: "HttpFailed exception ${parsedException.statusCode}"
		)
		is ConnectivityException ->
		GplayHttpRequestException(if (e is SocketTimeoutException) STATUS_CODE_TIMEOUT else -1, parsedException.message?: "")
		GplayHttpRequestException(
		if (e is SocketTimeoutException) STATUS_CODE_TIMEOUT else -1,
		parsedException.message ?: ""
		)
		else -> GplayHttpRequestException(-1, e.localizedMessage ?: "")
		}
		} finally {

app/src/main/java/foundation/e/apps/domain/entities/HttpExceptions.kt

+12 −4

Original line number	Diff line number	Diff line
		package foundation.e.apps.domain.entities

		open class HttpFailedCodeException(val statusCode: Int = 520, message: String? = null, cause: Throwable? = null ): Exception(message?: "", cause)
		open class HttpFailedCodeException(
		val statusCode: Int = 520,
		message: String? = null,
		cause: Throwable? = null
		) :
		Exception(message ?: "", cause)

		class HttpUnauthorizedException(message: String? = null, cause: Throwable? = null, ): HttpFailedCodeException(statusCode = 401, message = message, cause = cause)
		class HttpUnauthorizedException(message: String? = null, cause: Throwable? = null) :
		HttpFailedCodeException(statusCode = 401, message = message, cause = cause)

		class HttpTooManyRequestException(message: String? = null, cause: Throwable? = null): HttpFailedCodeException(statusCode = 429, message = message, cause = cause)
		class HttpTooManyRequestException(message: String? = null, cause: Throwable? = null) :
		HttpFailedCodeException(statusCode = 429, message = message, cause = cause)

		class ConnectivityException(message: String? = null, cause: Throwable) : Exception(message?: cause.message, cause)
		class ConnectivityException(message: String? = null, cause: Throwable) :
		Exception(message ?: cause.message, cause)

app/src/main/java/foundation/e/apps/domain/usecases/ReportFaultyGPlayUser.kt

+1 −2

Original line number	Diff line number	Diff line
		@@ -13,7 +13,6 @@ import timber.log.Timber
		import javax.inject.Inject
		import javax.inject.Singleton


		@Singleton
		class ReportFaultyGPlayUser @Inject constructor(
		private val playStoreRepository: PlayStoreRepository,