Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fb10348 authored by Fahim M. Choudhury's avatar Fahim M. Choudhury
Browse files

Merge branch '0000-fix-update-all-button-lifecycle-misuse' into 'main' 

fix(updates): remove redundant repeatOnLifecycle() call in Updates screen

See merge request !776
parents 8f469fc1 0d4002ae

app/src/main/java/foundation/e/apps/ui/updates/UpdatesFragment.kt

+2 −12
Original line number Diff line number Diff line
@@ -23,10 +23,8 @@ import android.view.View 
import androidx.appcompat.app.AlertDialog

import androidx.fragment.app.activityViewModels

import androidx.fragment.app.viewModels

import androidx.lifecycle.Lifecycle

import androidx.lifecycle.flowWithLifecycle

import androidx.lifecycle.lifecycleScope

import androidx.lifecycle.repeatOnLifecycle

import androidx.navigation.findNavController

import androidx.navigation.fragment.findNavController

import androidx.recyclerview.widget.LinearLayoutManager
@@ -164,21 +162,13 @@ class UpdatesFragment : TimeoutFragment(R.layout.fragment_updates), ApplicationI 
        WorkManager.getInstance(requireContext())

            .getWorkInfosLiveData(WorkQuery.fromStates(WorkInfo.State.entries))

            .observe(viewLifecycleOwner) {

                viewLifecycleOwner.lifecycleScope.launch {

                    repeatOnLifecycle(Lifecycle.State.RESUMED) {

                updateButtonAvailability()

            }

    }

            }

    }



    private fun setButtonEnabled(isEnabled: Boolean) {

        viewLifecycleOwner.lifecycleScope.launch {

            repeatOnLifecycle(Lifecycle.State.RESUMED) {

        binding.button.isEnabled = isEnabled

    }

        }

    }



    private fun updateButtonAvailability() {

        val areUpdatesAvailable = updatesViewModel.hasAnyUpdatableApp()