Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

Revert "Merge branch 'aayush_test' into 'v1-q'"

Aayush Gupta requested to merge revert-8ca58de5 into v1-q

Description

This MR reverts the previously merged commit which allows POWER_OFF alarm permission by default on devices as it results in boot loop of multiple devices.

--------- beginning of crash
03-30 11:12:39.618  1582  1582 E AndroidRuntime: *** FATAL EXCEPTION IN SYSTEM PROCESS: main
03-30 11:12:39.618  1582  1582 E AndroidRuntime: java.lang.IllegalArgumentException: Unknown permission: org.codeaurora.permission.POWER_OFF_ALARM
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.PermissionManagerService.grantRuntimePermission(PermissionManagerService.java:2175)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.PermissionManagerService.access$1000(PermissionManagerService.java:122)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.PermissionManagerService$PermissionManagerServiceInternalImpl.grantRuntimePermission(PermissionManagerService.java:3167)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.PackageManagerService.grantRuntimePermission(PackageManagerService.java:5865)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at android.app.ApplicationPackageManager.grantRuntimePermission(ApplicationPackageManager.java:696)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.DefaultPermissionGrantPolicy.grantRuntimePermissions(DefaultPermissionGrantPolicy.java:1277)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.DefaultPermissionGrantPolicy.grantDefaultPermissionExceptions(DefaultPermissionGrantPolicy.java:1441)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.permission.DefaultPermissionGrantPolicy.grantDefaultPermissions(DefaultPermissionGrantPolicy.java:322)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.pm.PackageManagerService.systemReady(PackageManagerService.java:21918)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.SystemServer.startOtherServices(SystemServer.java:2037)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.SystemServer.run(SystemServer.java:529)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.server.SystemServer.main(SystemServer.java:356)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
03-30 11:12:39.618  1582  1582 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:918)
--------- beginning of system

Related issues

e/backlog#1213 (closed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related MRs

Revert !67 (merged)

How has this been tested?

Build with this patch and notice devices boots without any issues

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Edited by Romain Hunault

Merge request reports

Loading