Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

vendor/lineage: Hookup TARGET_USES_MTK_APNS_CONF & copy mtk apns from tetris

Manu Sureshrequested to merge
1410-a14-mtk into a14

Description

Currently, APN configurations are maintained separately in multiple device repos.
It will be ideal to keep it commonized, to avoid multiple issues regarding APNs for each device.

Screenshots

Technical details

Introduce TARGET_USES_MTK_APNS_CONF variable to control which apn gets copied to product/etc/apns-conf.xml.
Existing behavior of copying apns is not affected unless TARGET_USES_MTK_APNS_CONF is set in BoardConfig.mk.

When TARGET_USES_MTK_APNS_CONF := true is set in BoardConfig.mk, mtk-specific apn config is copied.
When TARGET_USES_MTK_APNS_CONF := false is set in BoardConfig.mk, generic apn config is copied.
When TARGET_USES_MTK_APNS_CONF is not set in BoardConfig.mk, generic apn config is copied.

NOTE:
generic config refers to vendor/lineage/prebuilt/common/etc/apns-conf.xml.
mtk-specific config refers to vendor/lineage/prebuilt/common/etc/apns-conf-mtk.xml (introduced in this PR).

Tests

  • Build a14 for device with TARGET_USES_MTK_APNS_CONF := true set in BoardConfig.mk and check product/etc/apns-conf.xml.
    • product/etc/apns-conf.xml should contain mtk-specific apn config.
  • Build a14 for device with TARGET_USES_MTK_APNS_CONF := false set in BoardConfig.mk and check product/etc/apns-conf.xml.
    • product/etc/apns-conf.xml should contain generic apn config.
  • Build a14 for device with TARGET_USES_MTK_APNS_CONF not set in BoardConfig.mk and check product/etc/apns-conf.xml.
    • product/etc/apns-conf.xml should contain generic apn config.

Issues

https://gitlab.e.foundation/e/devices/backlog/-/issues/1410

10 commandments of code review

👪 ❤️ https://gitlab.e.foundation/groups/e/-/wikis/contribute/development-processes/code-review-guidelines

Edited by Manu Suresh

Merge request reports