Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content

eos: Exclude PicoTTS for 64bit only devices

Jackeagle requested to merge 7080-t-filter-picoTTS into v1-t

Description

While running build for axolotl device, which is a 64bit only device, PicoTTS started to error out as follows

build/make/core/main.mk:1312: warning:  device/shift/axolotl/lineage_axolotl.mk includes non-existent modules in PRODUCT_PACKAGES
Offending entries:
PicoTts
build/make/core/main.mk:1312: error: Build failed.

on investigation it is found that PicoTTS have issues with 64bit only devices and hence its best to not include PicoTTS on any device that is 64bit only.

This would not require any changes on Device specific sources and entirely is handled by build system.

Screenshots

Technical details

Tests

Issues

e/backlog#7080 (closed)

10 commandments of code reviews

👪 https://gitlab.e.foundation/internal/wiki/-/wikis/mobile-team/guidelines/Code-review

Edited by Jackeagle

Merge request reports

Loading