Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit f4d444e4 authored by Maciej Żenczykowski's avatar Maciej Żenczykowski Committed by Maciej Zenczykowski
Browse files

XfrmController.h - fix a virtual method call from destructor warning



Fixes:
  system/netd/server/XfrmController.h:67:29: error: Call to virtual method 'XfrmSocket::close' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]
      virtual ~XfrmSocket() { close(); }
                              ^
  system/netd/server/XfrmController.cpp:630:5: note: Taking false branch
      if (!isOk(ret)) {
      ^
  system/netd/server/XfrmController.cpp:636:5: note: Taking true branch
      if (!isOk(socketStatus)) {
      ^
  system/netd/server/XfrmController.cpp:638:16: note: Calling implicit destructor for 'XfrmSocketImpl'
          return socketStatus;
                 ^
  system/netd/server/XfrmController.cpp:638:16: note: Calling '~XfrmSocket'

Test: builds
Bug: 155351989
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Change-Id: I992c9899d9f9fc6a45fac28cad46db6331436099
Merged-In: I992c9899d9f9fc6a45fac28cad46db6331436099
parent 60741979
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment