Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa02bb99 authored by Rick Yiu's avatar Rick Yiu
Browse files

Revert "Add choice for changing sched policy when setting thread priority" 

This reverts commit 57affbf9.

Reason for revert: new API is no longer used

Change-Id: I97128c1d367e161aa50deaefa8b73a0f25e29af4
parent 290efe38

libutils/Threads.cpp

+12 −13
Original line number Diff line number Diff line
@@ -302,7 +302,8 @@ void androidSetCreateThreadFunc(android_create_thread_fn func) 
}



#if defined(__ANDROID__)

int androidSetThreadPriority(pid_t tid, int pri, bool change_policy) {

int androidSetThreadPriority(pid_t tid, int pri)

{

    int rc = 0;

    int lasterr = 0;

    int curr_pri = getpriority(PRIO_PROCESS, tid);
@@ -311,7 +312,6 @@ int androidSetThreadPriority(pid_t tid, int pri, bool change_policy) { 
        return rc;

    }



    if (change_policy) {

    if (pri >= ANDROID_PRIORITY_BACKGROUND) {

        rc = SetTaskProfiles(tid, {"SCHED_SP_BACKGROUND"}, true) ? 0 : -1;

    } else if (curr_pri >= ANDROID_PRIORITY_BACKGROUND) {
@@ -324,7 +324,6 @@ int androidSetThreadPriority(pid_t tid, int pri, bool change_policy) { 
    if (rc) {

        lasterr = errno;

    }

    }



    if (setpriority(PRIO_PROCESS, tid, pri) < 0) {

        rc = INVALID_OPERATION;

libutils/include/utils/AndroidThreads.h

+1 −3
Original line number Diff line number Diff line
@@ -78,9 +78,7 @@ extern void androidSetCreateThreadFunc(android_create_thread_fn func); 
// should be one of the ANDROID_PRIORITY constants.  Returns INVALID_OPERATION

// if the priority set failed, else another value if just the group set failed;

// in either case errno is set.  Thread ID zero means current thread.

// Parameter "change_policy" indicates if sched policy should be changed. It needs

// not be checked again if the change is done elsewhere like activity manager.

extern int androidSetThreadPriority(pid_t tid, int prio, bool change_policy = true);

extern int androidSetThreadPriority(pid_t tid, int prio);



// Get the current priority of a particular thread. Returns one of the

// ANDROID_PRIORITY constants or a negative result in case of error.