Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d78f3df6 authored by Nathan Bullock's avatar Nathan Bullock Committed by chrome-internal-fetch
Browse files

libchromeos: void OsReleaseReader.Load() 

Previously OsReleaseReader returned a bool, which meant that code that
called load wanted to CHECK the return values and possibly log warning
messages, etc. This was unecessary since OsReleaseReader.Load never
returns false.

TEST=unittests
BUG=none

Change-Id: I7064c6a788897b5d5c687d6c9c5f4e03d4ca21a7
Reviewed-on: https://chromium-review.googlesource.com/223990


Reviewed-by: default avatarBertrand Simonnet <bsimonnet@google.com>
Commit-Queue: Nathan Bullock <nathanbullock@google.com>
Tested-by: default avatarNathan Bullock <nathanbullock@google.com>
parent cac74e12

metrics/uploader/system_profile_cache.cc

+2 −3
Original line number Diff line number Diff line
@@ -150,10 +150,9 @@ bool SystemProfileCache::GetProductId(int* product_id) const { 
  chromeos::OsReleaseReader reader;

  if (testing_) {

    base::FilePath root(config_root_);

    CHECK(reader.LoadTestingOnly(root)) << "Failed to load os-release fields "

                                        "from" << root.value();

    reader.LoadTestingOnly(root);

  } else {

    CHECK(reader.Load()) << "Failed to load os-release fields.";

    reader.Load();

  }



  std::string id;