Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc4a15b9 authored by Eric Biggers's avatar Eric Biggers
Browse files

fs_mgr_fstab: allow fileencryption without equals sign 

A point of confusion that has been encountered recently is that the
fileencryption argument is optional (since Android 11), yet the fstab
parser requires the equals sign in "fileencryption=".  Thus, someone
wanting to use the default options must use "...,fileencryption=,...".

Make "fileencryption" by itself mean the same thing so that it works as
expected.

Test: atest CtsFsMgrTestCases
Change-Id: I65ce6b9513942bec2107838396835e7aafb3bf37
parent 9bf90f14

fs_mgr/fs_mgr_fstab.cpp

+3 −1
Original line number Diff line number Diff line
@@ -242,7 +242,9 @@ bool ParseFsMgrFlags(const std::string& flags, FstabEntry* entry) { 
                    LWARNING << "Warning: zramsize= flag malformed: " << arg;

                }

            }

        } else if (StartsWith(flag, "fileencryption=")) {

        } else if (StartsWith(flag, "fileencryption=") || flag == "fileencryption") {

            // "fileencryption" enables file-based encryption.  It's normally followed by an = and

            // then the encryption options.  But that can be omitted to use the default options.

            ParseFileEncryption(arg, entry);

        } else if (StartsWith(flag, "max_comp_streams=")) {

            if (!ParseInt(arg, &entry->max_comp_streams)) {

fs_mgr/tests/fs_mgr_test.cpp

+1 −0
Original line number Diff line number Diff line
@@ -497,6 +497,7 @@ source none1 swap defaults fileencryption=,keydirectory=,length=,sw 
    EXPECT_EQ("none0", entry->mount_point);

    {

        FstabEntry::FsMgrFlags flags = {};

        flags.file_encryption = true;

        EXPECT_TRUE(CompareFlags(flags, entry->fs_mgr_flags));

    }

    EXPECT_EQ("", entry->metadata_key_dir);