Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd70e4ac authored by Raphael Moll's avatar Raphael Moll
Browse files

Define O_BINARY for non-Windows platforms. 

All tools (aapt, aidl, dexdump, etc.) need this flag to open()
binary files, or they risk reading corrupted data on Windows.

A bunch of these tools just conditionaly define O_BINARY in
their C files. Seems it would just make sense to define it globally.

Change-Id: Ia5c0a59e9e77bbdcbce235233555f611207abed8
parent 034117e4

include/arch/darwin-x86/AndroidConfig.h

+8 −0
Original line number Diff line number Diff line
@@ -300,4 +300,12 @@ 
 */

#define HAVE_PRINTF_ZD 1



/*

 * We need to open binary files using O_BINARY on Windows.

 * Most systems lack (and actually don't need) this flag.

 */

#ifndef O_BINARY

#define O_BINARY 0

#endif



#endif /*_ANDROID_CONFIG_H*/

include/arch/freebsd-x86/AndroidConfig.h

+8 −0
Original line number Diff line number Diff line
@@ -358,4 +358,12 @@ 
 */

#define HAVE_PRINTF_ZD 1



/*

 * We need to open binary files using O_BINARY on Windows.

 * Most systems lack (and actually don't need) this flag.

 */

#ifndef O_BINARY

#define O_BINARY 0

#endif



#endif /*_ANDROID_CONFIG_H*/

include/arch/linux-arm/AndroidConfig.h

+8 −0
Original line number Diff line number Diff line
@@ -354,4 +354,12 @@ 
 */

#define HAVE_PRINTF_ZD 1



/*

 * We need to open binary files using O_BINARY on Windows.

 * Most systems lack (and actually don't need) this flag.

 */

#ifndef O_BINARY

#define O_BINARY 0

#endif



#endif /* _ANDROID_CONFIG_H */

include/arch/linux-ppc/AndroidConfig.h

+8 −0
Original line number Diff line number Diff line
@@ -318,4 +318,12 @@ 
 */

#define HAVE_PREAD 1



/*

 * We need to open binary files using O_BINARY on Windows.

 * Most systems lack (and actually don't need) this flag.

 */

#ifndef O_BINARY

#define O_BINARY 0

#endif



#endif /*_ANDROID_CONFIG_H*/

include/arch/linux-sh/AndroidConfig.h

+8 −0
Original line number Diff line number Diff line
@@ -361,4 +361,12 @@ 
 */

#define HAVE_PRINTF_ZD 1



/*

 * We need to open binary files using O_BINARY on Windows.

 * Most systems lack (and actually don't need) this flag.

 */

#ifndef O_BINARY

#define O_BINARY 0

#endif



#endif /* _ANDROID_CONFIG_H */