Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 965d6f4d authored by Josh Gao's avatar Josh Gao
Browse files

debuggerd: don't send SIGSTOP to crashing processes. 

This was actually nonfunctional until f5e8f0b9, because it was using kill
after privileges were dropped. This doesn't seem necessary after the
changes to the sibling thread ptrace logic, though.

Bug: http://b/27427439
Change-Id: I6bffbc14e0cf5e377bbfa39c945518e0d436c223
(cherry picked from commit b17f228f)
parent 290127b2

debuggerd/debuggerd.cpp

+0 −5
Original line number Diff line number Diff line
@@ -417,12 +417,7 @@ static bool perform_dump(const debugger_request_t& request, int fd, int tombston 
#endif

      case SIGTRAP:

        ALOGV("stopped -- fatal signal\n");

        // Send a SIGSTOP to the process to make all of

        // the non-signaled threads stop moving.  Without

        // this we get a lot of "ptrace detach failed:

        // No such process".

        *crash_signal = signal;

        send_signal(request.pid, 0, SIGSTOP);

        engrave_tombstone(tombstone_fd, backtrace_map, request.pid, request.tid, siblings, signal,

                          request.original_si_code, request.abort_msg_address);

        break;