Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9515c23e authored by Josh Gao's avatar Josh Gao
Browse files

debuggerd: use O_NOFOLLOW|O_CLOEXEC for tombstones. DO NOT MERGE 

Effectively a cherry-pick of 04f9b2a8.

Bug: http://b/26403620
Change-Id: I0437fdc774501f428d8b4f8dd7682b32eaa29cef
parent 9c0ed663

debuggerd/tombstone.c

+2 −2
Original line number Diff line number Diff line
@@ -759,7 +759,7 @@ static char* find_and_open_tombstone(int* fd) 
        if (errno != ENOENT)

            continue;



        *fd = open(path, O_CREAT | O_EXCL | O_WRONLY, 0600);

        *fd = open(path, O_CREAT | O_EXCL | O_WRONLY | O_NOFOLLOW | O_CLOEXEC, 0600);

        if (*fd < 0)

            continue;   /* raced ? */
@@ -769,7 +769,7 @@ static char* find_and_open_tombstone(int* fd) 


    /* we didn't find an available file, so we clobber the oldest one */

    snprintf(path, sizeof(path), TOMBSTONE_DIR"/tombstone_%02d", oldest);

    *fd = open(path, O_CREAT | O_TRUNC | O_WRONLY, 0600);

    *fd = open(path, O_CREAT | O_TRUNC | O_WRONLY | O_NOFOLLOW | O_CLOEXEC, 0600);

    if (*fd < 0) {

        LOG("failed to open tombstone file '%s': %s\n", path, strerror(errno));

        return NULL;