debuggerd: use O_NOFOLLOW|O_CLOEXEC for tombstones (04f9b2a8) · Commits · e / os / android_system_core

debuggerd/tombstone.cpp

100755 → 100644

+2 −2

Original line number	Diff line number	Diff line
		@@ -674,7 +674,7 @@ static char* find_and_open_tombstone(int* fd) {
		if (errno != ENOENT)
		continue;

		*fd = open(path, O_CREAT \| O_EXCL \| O_WRONLY, 0600);
		*fd = open(path, O_CREAT \| O_EXCL \| O_WRONLY \| O_NOFOLLOW \| O_CLOEXEC, 0600);
		if (*fd < 0)
		continue; // raced ?

		@@ -689,7 +689,7 @@ static char* find_and_open_tombstone(int* fd) {

		// we didn't find an available file, so we clobber the oldest one
		snprintf(path, sizeof(path), TOMBSTONE_TEMPLATE, oldest);
		*fd = open(path, O_CREAT \| O_TRUNC \| O_WRONLY, 0600);
		*fd = open(path, O_CREAT \| O_TRUNC \| O_WRONLY \| O_NOFOLLOW \| O_CLOEXEC, 0600);
		if (*fd < 0) {
		ALOGE("failed to open tombstone file '%s': %s\n", path, strerror(errno));
		return NULL;