Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b474de4 authored by Christopher Ferris's avatar Christopher Ferris
Browse files

Set groups before dropping privileges. 

The code for dumping tombstones tries to read the log data. This was
silently failing after the change to drop root privileges. Fix this
by explicitly setting the groups allowed before dropping privileges.

Bug: 28590884
(cherry picked from commit edc23801)

Change-Id: I225365edccb11f8752027566fd42f3b10ce10260
parent 830561bb

debuggerd/debuggerd.cpp

+10 −2
Original line number Diff line number Diff line
@@ -511,13 +511,21 @@ static bool perform_dump(const debugger_request_t& request, int fd, int tombston 
}



static bool drop_privileges() {

  // AID_LOG: for reading the logs data associated with the crashing process.

  // AID_READPROC: for reading /proc/<PID>/{comm,cmdline}.

  gid_t groups[] = { AID_DEBUGGERD, AID_LOG, AID_READPROC };

  if (setgroups(sizeof(groups)/sizeof(groups[0]), groups) != 0) {

    ALOGE("debuggerd: failed to setgroups: %s", strerror(errno));

    return false;

  }



  if (setresgid(AID_DEBUGGERD, AID_DEBUGGERD, AID_DEBUGGERD) != 0) {

    ALOGE("debuggerd: failed to setresgid");

    ALOGE("debuggerd: failed to setresgid: %s", strerror(errno));

    return false;

  }



  if (setresuid(AID_DEBUGGERD, AID_DEBUGGERD, AID_DEBUGGERD) != 0) {

    ALOGE("debuggerd: failed to setresuid");

    ALOGE("debuggerd: failed to setresuid: %s", strerror(errno));

    return false;

  }