Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81ab11af authored by Mark Salyzyn's avatar Mark Salyzyn
Browse files

logd: liblog benchmark check BM_log_overhead regression 

Failed to acquire BM_log_print_overhead as it was renamed from
BM_log_overhead in commit 8f2492f5
(liblog: benchmark: Use local LOGGER_NULL frontend')

The test report would not clearly identify which entry was missing, or
unparsed, so unrolled the loop and incorporating the indexes by name
so that gTest failure report offers a much better clue to the problem.

Test: gTest logd-unit-tests --gtest=logd.benchmark
Bug: 36683634
Bug: 27405083
Change-Id: Ic590c230569871651fb716054ecf635385d0f8a2
parent fe8c96d1

logd/tests/logd_test.cpp

+11 −9
Original line number Diff line number Diff line
@@ -426,7 +426,7 @@ TEST(logd, benchmark) { 
                    " BM_log_maximum_retry"

                    " BM_log_maximum"

                    " BM_clock_overhead"

                    " BM_log_overhead"

                    " BM_log_print_overhead"

                    " BM_log_latency"

                    " BM_log_delay",

                    "r")));
@@ -435,12 +435,12 @@ TEST(logd, benchmark) { 


    static const char* benchmarks[] = {

        "BM_log_maximum_retry ",  "BM_log_maximum ", "BM_clock_overhead ",

        "BM_log_overhead ",      "BM_log_latency ", "BM_log_delay "

        "BM_log_print_overhead ", "BM_log_latency ", "BM_log_delay "

    };

    static const unsigned int log_maximum_retry = 0;

    static const unsigned int log_maximum = 1;

    static const unsigned int clock_overhead = 2;

    static const unsigned int log_overhead = 3;

    static const unsigned int log_print_overhead = 3;

    static const unsigned int log_latency = 4;

    static const unsigned int log_delay = 5;
@@ -469,21 +469,23 @@ TEST(logd, benchmark) { 
    }



    EXPECT_GE(200000UL, ns[log_maximum_retry]);  // 104734 user

    EXPECT_NE(0UL, ns[log_maximum_retry]);       // failure to parse



    EXPECT_GE(90000UL, ns[log_maximum]);  // 46913 user

    EXPECT_NE(0UL, ns[log_maximum]);      // failure to parse



    EXPECT_GE(4096UL, ns[clock_overhead]);  // 4095

    EXPECT_NE(0UL, ns[clock_overhead]);     // failure to parse



    EXPECT_GE(250000UL, ns[log_overhead]);  // 126886 user

    EXPECT_GE(250000UL, ns[log_print_overhead]);  // 126886 user

    EXPECT_NE(0UL, ns[log_print_overhead]);       // failure to parse



    EXPECT_GE(10000000UL,

              ns[log_latency]);  // 1453559 user space (background cgroup)

    EXPECT_NE(0UL, ns[log_latency]);  // failure to parse



    EXPECT_GE(20000000UL, ns[log_delay]);  // 10500289 user



    for (unsigned i = 0; i < arraysize(ns); ++i) {

        EXPECT_NE(0UL, ns[i]);

    }

    EXPECT_NE(0UL, ns[log_delay]);         // failure to parse



    alloc_statistics(&buf, &len);