Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ad965bf authored by Josh Gao's avatar Josh Gao
Browse files

crash_dump: fix overflow. 

`1 << 32` overflows, resulting in bogus PR_CAP_AMBIENT_RAISE attempts,
and breaking dumping for processes with capabilities in the top 32 bits.

Bug: http://b/35241370
Test: debuggerd -b `pidof com.android.bluetooth`
Change-Id: I29c45a8bd36bdeb3492c9f74599993c139821088
parent 2a18b822

debuggerd/handler/debuggerd_handler.cpp

+1 −1
Original line number Diff line number Diff line
@@ -202,7 +202,7 @@ static void raise_caps() { 
  uint64_t capmask = capdata[0].inheritable;

  capmask |= static_cast<uint64_t>(capdata[1].inheritable) << 32;

  for (unsigned long i = 0; i < 64; ++i) {

    if (capmask & (1 << i)) {

    if (capmask & (1ULL << i)) {

      if (prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, i, 0, 0) != 0) {

        __libc_format_log(ANDROID_LOG_ERROR, "libc", "failed to raise ambient capability %lu: %s",

                          i, strerror(errno));