Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50e244b2 authored by Lorenzo Colitti's avatar Lorenzo Colitti
Browse files

Revert "Make the xtables lock readable only by AID_RADIO and root." 

This reverts commit 5e801e7b.

The file permissions don't allow access to the lock on devices
where vendor code runs with UID root and GID radio. They are
no longer necessary because we have a more flexible selinux-based
solution in https://android-review.googlesource.com/#/c/354223/ .

Test: strace -f -e flock -p <netmgrd_pid> on angler shows flock succeeds
Test: strace -f -e flock -p <netmgrd_pid> on marlin shows flock succeeds
Test: netd_unit_test passes on marlin
Test: strace -f -e flock -p <netd_pid> on marlin shows flock succeeds
Bug: 36108349
Bug: 37483189

(cherry picked from commit b6e4b35f)

Change-Id: Ia1bbf8d93ec6777514be66cbd1a32dfc95df95c0
Merged-In: Ia1bbf8d93ec6777514be66cbd1a32dfc95df95c0
parent 02012596

libcutils/fs_config.c

+0 −1
Original line number Diff line number Diff line
@@ -158,7 +158,6 @@ static const struct fs_path_config android_files[] = { 
    { 00555, AID_ROOT,      AID_ROOT,      0, "system/etc/ppp/*" },

    { 00555, AID_ROOT,      AID_ROOT,      0, "system/etc/rc.*" },

    { 00440, AID_ROOT,      AID_ROOT,      0, "system/etc/recovery.img" },

    { 00440, AID_RADIO,     AID_ROOT,      0, "system/etc/xtables.lock" },

    { 00600, AID_ROOT,      AID_ROOT,      0, "vendor/build.prop" },

    { 00600, AID_ROOT,      AID_ROOT,      0, "vendor/default.prop" },

    { 00444, AID_ROOT,      AID_ROOT,      0, ven_conf_dir + 1 },