Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 500ed210 authored by Kelvin Zhang's avatar Kelvin Zhang
Browse files

Use insert() with ranges instead of reserve 

STL implementation of insert() is generally smart enough to reserve
storage before hand. No need to do reserve() followed by for each loop

Test: th
Change-Id: I36e88c121868b97ea525b292a67b36983c530e56
parent 12e5f038

fs_mgr/libsnapshot/cow_reader.cpp

+1 −4
Original line number Diff line number Diff line
@@ -475,10 +475,7 @@ bool CowReader::PrepMergeOps() { 
        std::sort(other_ops.begin(), other_ops.end(), std::greater<int>());

    }



    merge_op_blocks->reserve(merge_op_blocks->size() + other_ops.size());

    for (auto block : other_ops) {

        merge_op_blocks->emplace_back(block);

    }

    merge_op_blocks->insert(merge_op_blocks->end(), other_ops.begin(), other_ops.end());



    num_total_data_ops_ = merge_op_blocks->size();

    if (header_.num_merge_ops > 0) {