Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f301cd9 authored by Jiyong Park's avatar Jiyong Park
Browse files

Suppress lint warnings on google-default-arguments 

The lint rule google-default-arguments ensures that virtual or override
methods do not have default arguments, because different default values
across the hierarchy chain (e.g. Base::foo(int a=0) v.s.
Derived::foo(int a=10)) can cause confusions.

However, since the uses of the default arguments in libbinder don't lead
to such problem, suppress the warnings.

Test: WITH_TIDY=true WITH_TIDY_CHECKS=google-default-arguments m
libbinder does not show any warning about google-default-arguments

Change-Id: Ica41034ab0ad1037a0facc447ee47e0c77fa9c55
parent 959aea7e

libutils/include/utils/Thread.h

+1 −0
Original line number Diff line number Diff line
@@ -47,6 +47,7 @@ public: 
    virtual             ~Thread();



    // Start the thread in threadLoop() which needs to be implemented.

    // NOLINTNEXTLINE(google-default-arguments)

    virtual status_t    run(    const char* name,

                                int32_t priority = PRIORITY_DEFAULT,

                                size_t stack = 0);