Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d998ea9 authored by Alex Naidis's avatar Alex Naidis
Browse files

libcutils: Clarify schedboost_enabled() 



Commit 795267d4 ("Removed cpusets/schedboost build time dependency.")
turned the cpusets and schedtune options into runtime
decisions.

However the kernel option which is mentioned in the
code comment (CONFIG_SCHEDTUNE) is very misleading
as it doesn't exist (CONFIG_SCHED_TUNE does exist)
and it doesn't describe the real functionality of
the method. schedboost_enabled() will still return
false if CONFIG_SCHED_TUNE is set in the kernel but
CONFIG_CGROUP_SCHEDTUNE is not.

So to clarify this, we need to change the comment
to reflect that CONFIG_CGROUP_SCHEDTUNE, which depends
on CONFIG_SCHED_TUNE, is required.

Signed-off-by: default avatarAlex Naidis <alex.naidis@linux.com>
parent 6794bc7d

libcutils/include/cutils/sched_policy.h

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ extern bool cpusets_enabled(); 
 * Check if Linux kernel enables SCHEDTUNE feature (only available in Android

 * common kernel or Linaro LSK, not in mainline Linux as of v4.9)

 *

 * Return value: 1 if Linux kernel CONFIG_SCHEDTUNE=y; 0 otherwise.

 * Return value: 1 if Linux kernel CONFIG_CGROUP_SCHEDTUNE=y; 0 otherwise.

 */

extern bool schedboost_enabled();

libcutils/sched_policy.cpp

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ bool cpusets_enabled() { 


/*

    Similar to CONFIG_CPUSETS above, but with a different configuration

    CONFIG_SCHEDTUNE that's in Android common Linux kernel and Linaro

    CONFIG_CGROUP_SCHEDTUNE that's in Android common Linux kernel and Linaro

    Stable Kernel (LSK), but not in mainline Linux as of v4.9.



    With runtime check using the following function, build time