Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2009e320 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Support zero-length mapped files"

parents 22ff8e19 5d7f8414

base/mapped_file.cpp

+8 −1
Original line number Diff line number Diff line
@@ -41,7 +41,14 @@ std::unique_ptr<MappedFile> MappedFile::FromFd(int fd, off64_t offset, size_t le 
  HANDLE handle =

      CreateFileMapping(reinterpret_cast<HANDLE>(_get_osfhandle(fd)), nullptr,

                        (prot & PROT_WRITE) ? PAGE_READWRITE : PAGE_READONLY, 0, 0, nullptr);

  if (handle == nullptr) return nullptr;

  if (handle == nullptr) {

    // http://b/119818070 "app crashes when reading asset of zero length".

    // Return a MappedFile that's only valid for reading the size.

    if (length == 0) {

      return std::unique_ptr<MappedFile>(new MappedFile{nullptr, 0, 0, nullptr});

    }

    return nullptr;

  }

  void* base = MapViewOfFile(handle, (prot & PROT_WRITE) ? FILE_MAP_ALL_ACCESS : FILE_MAP_READ, 0,

                             file_offset, file_length);

  if (base == nullptr) {