Commit 19b500bd authored Feb 21, 2020 by George Burgess IV

incremental_server: fix a use of uninitalized memory

Without this, the caller is likely to assume that their buffer is
fully usable, which clang's analyzer doesn't believe is the case.

Another option is to set `*size` to nonzero.

Caught by the static analyzer:
system/core/adb/client/incremental_server.cpp:111:31: warning: 1st
function call argument is an uninitialized value
[clang-analyzer-core.CallAndMessage]

Bug: None
Test: TreeHugger
Change-Id: Ib844aa4ab3ebb297ca8f6f4289bbe3212275275b

parent e20d3a00

adb/client/incremental_server.cpp

+1 −1

Original line number	Diff line number	Diff line
		@@ -258,7 +258,7 @@ bool IncrementalServer::SkipToRequest(void* buffer, size_t* size, bool blocking)

		if (r == -1) {
		fprintf(stderr, "Failed to read from fd %d: %d. Exit\n", adb_fd_.get(), errno);
		return true;
		return false;
		}

		// socket is closed