Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15800946 authored by Tom Cherry's avatar Tom Cherry
Browse files

__android_log_is_debuggable() shouldn't be an apex symbol 

Remove a superfluous check in fs_mgr, since those return values are
already impossible for a non-debuggable build.  Replace a one time
call to __android_log_is_debuggable(), since there's no reason to
cache the value or use this symbol.

Test: build
Change-Id: Icd4bef7b616c49d304303747388d7e3018c6fcfc
parent fe1f7017

fs_mgr/fs_mgr.cpp

+2 −6
Original line number Diff line number Diff line
@@ -1098,9 +1098,7 @@ int fs_mgr_mount_all(Fstab* fstab, int mount_mode) { 
            }

        } else if ((current_entry.fs_mgr_flags.verify)) {

            int rc = fs_mgr_setup_verity(&current_entry, true);

            if (__android_log_is_debuggable() &&

                    (rc == FS_MGR_SETUP_VERITY_DISABLED ||

                     rc == FS_MGR_SETUP_VERITY_SKIPPED)) {

            if (rc == FS_MGR_SETUP_VERITY_DISABLED || rc == FS_MGR_SETUP_VERITY_SKIPPED) {

                LINFO << "Verity disabled";

            } else if (rc != FS_MGR_SETUP_VERITY_SUCCESS) {

                LERROR << "Could not set up verified partition, skipping!";
@@ -1331,9 +1329,7 @@ static int fs_mgr_do_mount_helper(Fstab* fstab, const std::string& n_name, 
            }

        } else if (fstab_entry.fs_mgr_flags.verify) {

            int rc = fs_mgr_setup_verity(&fstab_entry, true);

            if (__android_log_is_debuggable() &&

                    (rc == FS_MGR_SETUP_VERITY_DISABLED ||

                     rc == FS_MGR_SETUP_VERITY_SKIPPED)) {

            if (rc == FS_MGR_SETUP_VERITY_DISABLED || rc == FS_MGR_SETUP_VERITY_SKIPPED) {

                LINFO << "Verity disabled";

            } else if (rc != FS_MGR_SETUP_VERITY_SUCCESS) {

                LERROR << "Could not set up verified partition, skipping!";

libcutils/trace-dev.inc

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static bool atrace_is_cmdline_match(const char* cmdline) 
// Determine whether application-level tracing is enabled for this process.

static bool atrace_is_app_tracing_enabled()

{

    bool sys_debuggable = __android_log_is_debuggable();

    bool sys_debuggable = property_get_bool("ro.debuggable", 0);

    bool result = false;



    if (sys_debuggable || atrace_is_debuggable) {

liblog/liblog.map.txt

+1 −1
Original line number Diff line number Diff line
@@ -51,7 +51,7 @@ LIBLOG_M { 
LIBLOG_O {

  global:

    __android_log_is_loggable_len;

    __android_log_is_debuggable; # apex vndk

    __android_log_is_debuggable; # vndk

};



LIBLOG_Q {