Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b771b33 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Stop writing NUL bytes in adbkey.pub. 

In N we moved some code from C to C++ without realizing that EVP_EncodedLength
includes space for a terminating NUL and EVP_EncodeBlock writes one. Because
our key reading code copes with the NUL, we never noticed.

Distinguish between the required space returned by EVP_EncodedLength and the
actual number of bytes (not including NUL) used return by EVP_EncodeBlock.

Bug: http://b/36187819
Test: hexdump of ~/.android/adbkey.pub
Change-Id: I81a487ddbb5c884593b6426d1f41cfaece26ff90
parent 16214f29

adb/adb_auth_host.cpp

+6 −5
Original line number Diff line number Diff line
@@ -82,16 +82,17 @@ static bool write_public_keyfile(RSA* private_key, const std::string& private_ke 
        return false;

    }



    size_t base64_key_length;

    if (!EVP_EncodedLength(&base64_key_length, sizeof(binary_key_data))) {

    size_t expected_length;

    if (!EVP_EncodedLength(&expected_length, sizeof(binary_key_data))) {

        LOG(ERROR) << "Public key too large to base64 encode";

        return false;

    }



    std::string content;

    content.resize(base64_key_length);

    base64_key_length = EVP_EncodeBlock(reinterpret_cast<uint8_t*>(&content[0]), binary_key_data,

    content.resize(expected_length);

    size_t actual_length = EVP_EncodeBlock(reinterpret_cast<uint8_t*>(&content[0]), binary_key_data,

                                           sizeof(binary_key_data));

    content.resize(actual_length);



    content += get_user_info();