Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09175a02 authored by George Burgess IV's avatar George Burgess IV
Browse files

Add mode bits to a call to open with O_CREAT 

Open with O_CREAT needs mode bits: https://linux.die.net/man/3/open

Found by running clang FORTIFY over AOSP.

Bug: 32073964
Test: Now builds with clang FORTIFY.
Change-Id: Iee4c93c5482f510e0adf8104c27e394b5d87ec88
parent 5b202c43

libcutils/fs.c

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static int fs_prepare_path_impl(const char* path, mode_t mode, uid_t uid, gid_t 
create:

    create_result = prepare_as_dir

        ? TEMP_FAILURE_RETRY(mkdir(path, mode))

        : TEMP_FAILURE_RETRY(open(path, O_CREAT | O_CLOEXEC | O_NOFOLLOW | O_RDONLY));

        : TEMP_FAILURE_RETRY(open(path, O_CREAT | O_CLOEXEC | O_NOFOLLOW | O_RDONLY, 0644));

    if (create_result == -1) {

        if (errno != EEXIST) {

            ALOGE("Failed to %s(%s): %s",