Ensure service unbind when receiving a null call screening service in onBind.
Currently, we do not unbind the call screening service when a null service is returned from onBind when placing MO calls. CallScreeningServiceHelper (MO) now overrides onNullBinding to ensure future completion and that we unbind the service after. Similarly, we need to unbind the service in onServiceDisconnected. CallScreeningServiceFilter (MT) has also been updated to ensure we unbind in places when we know that the connection should not exist. Also, there is a timeout in CallScreeningServiceHelper. This does not require a call to unbind the service because CallScreeningAdapter also places a call to unbind the service in onScreeningResponse. We would risk having duplicate calls to unbind the service, which would cause a fatal exception. This is demonstrated by the existing CTS tests, namely, ThirdPartyCallScreeningServiceTest.java. Bug: 252762941 Test: Manual (no breakage in existing flow), CTS for MO/MT cases Change-Id: Ia5b62bb93dc666b6b8b8daccb8ef41eb55dde7ea Merged-In: Ia5b62bb93dc666b6b8b8daccb8ef41eb55dde7ea (cherry picked from commit 14927c6f) Merged-In: Ia5b62bb93dc666b6b8b8daccb8ef41eb55dde7ea
Loading
Please register or sign in to comment