Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e3d5ec34 authored by wescande's avatar wescande Committed by William Escande
Browse files

Discard unused RFA bit in volume. 

As said in `6.13.1 Absolute Volume`
  An Absolute Volume is represented in one octet.
  The top bit (bit 7) is reserved for future addition (RFA)

Tag: #feature
Bug: 193685553
Fix: 193685553
Test: atest BluetoothInstrumentationTests
Change-Id: I7e8180d92bc39a7333e00ff6d568ad20e63e13f7
parent fd170e1c

system/profile/avrcp/device.cc

+2 −0
Original line number Diff line number Diff line
@@ -387,6 +387,7 @@ void Device::HandleVolumeChanged( 
  // Handle the first volume update.

  if (volume_ == VOL_NOT_SUPPORTED) {

    volume_ = pkt->GetVolume();

    volume_ &= ~0x80;  // remove RFA bit

    volume_interface_->DeviceConnected(

        GetAddress(),

        base::Bind(&Device::SetVolume, weak_ptr_factory_.GetWeakPtr()));
@@ -403,6 +404,7 @@ void Device::HandleVolumeChanged( 
  }



  volume_ = pkt->GetVolume();

  volume_ &= ~0x80;  // remove RFA bit

  DEVICE_VLOG(1) << __func__ << ": Volume has changed to " << (uint32_t)volume_;

  volume_interface_->SetVolume(volume_);

}