Create include/check.h to use different headers for CHECK-macros.
A few months ago, Chrome OS libchrome has followed Chrome upstream, to move CHECK-related macros to base/check.h and base/check_op.h. An implicit include of base/check.h and base/check_op.h was added to base/logging.h for short-term backward compatibility until all CHECK-related usages have been migrated. We're planning to remove this implicit include soon. Android is still using older libchrome, and CHECK-related macros lives in base/logging.h. Thus adding a wrapper header as include/check.h like include/notreached.h. include of <base/logging.h> is still kept, and not removed. Because, base/logging.h is still implicitly included by base/check.h, and this CL doesn't really look into usages of LOG(). Removing base/logging.h may accidentally adds implicit usages via base/check.h. We will be removing the implicit include in base/check.h later. It might be better to keep base/logging.h and reinvestigate, and remove unnecessary base/logging.h later to avoid unnecessary blocking items when reomving implicit include from base/check.h. Bug: 186486897 Tag: #floss Test: FEATURES=test emerge-zork-floss floss Change-Id: I6211d1c5d41623d9df8e7b48c90cf0ce6c64eb72
Loading
Please register or sign in to comment