PDL: run the expected code through ‘rustfmt’ as well
Before we only formatted the newly generated code. The idea was to compare this with the known-good code stored in the repository. However, this requires us to carefully control the ‘rustfmt’ configuration: in particular, we need to copy a ‘rustfmt.toml’ file into the directory from which we invoke ‘rustfmt’. We can avoid this if we simply format both the new and the existing code: this was the current settings of ‘rustfmt’ will take effect for both pieces of code and we will be able to compare them for equality. This change means that we don’t have to update any of the existing known-good files if/when the common ‘rustfmt.toml’ files changes. This change makes https://r.android.com/2096444 obsolete. Test: atest 'pdl*' Change-Id: I732cec8e08c8c8e8b70f40a1d074faecc89979ff
Loading
Please register or sign in to comment