Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a2b8650 authored by Yi Kong's avatar Yi Kong
Browse files

Fix incorrect boolean logic 

Original code:
  isLittleEndian || isBigEndian && isLittleEndian != isBigEndian

By the default association rules, this is equivalent to:
  isLittleEndian || (isBigEndian && isLittleEndian != isBigEndian)

this apparently is not the intended logic. Fixed to
  (isLittleEndian || isBigEndian) && (isLittleEndian != isBigEndian)

Test: presubmit
Change-Id: I45a273bfbb7a8c492c1455020c23130d105cebdf
parent cd4a93df

system/gd/hal/snoop_logger_common.h

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ constexpr uint32_t kBytesToTest = 0x12345678; 
constexpr uint8_t kFirstByte = (const uint8_t&)kBytesToTest;

constexpr bool isLittleEndian = kFirstByte == 0x78;

constexpr bool isBigEndian = kFirstByte == 0x12;

static_assert(isLittleEndian || isBigEndian && isLittleEndian != isBigEndian);

static_assert((isLittleEndian || isBigEndian) && (isLittleEndian != isBigEndian));



constexpr uint32_t BTSNOOP_VERSION_NUMBER = isLittleEndian ? 0x01000000 : 1;

constexpr uint32_t BTSNOOP_DATALINK_TYPE =