Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af35481f authored by Mark Chien's avatar Mark Chien
Browse files

Remove unused ACCESS_NETWORK_STATE permission 

Since TetheringCoverageTests would include NetworkStackTestsLib and
tethering has unit test case that tests ACCESS_NETWORK_STATE permission.
That test would assume the test package do not define
ACCESS_NETWORK_STATE permission and use adopt/drop shell permission to
simulate whether caller hold ACCESS_NETWORK_STATE permission.

Since NetworkStackTests do not use ACCESS_NETWORK_STATE permission,
remove it to avoid to be inherited by its user(TetheringCoverageTests).

Bug: 154869719
Test: TetheringCoverageTests, NetworkStackTests, NetworkStackNextTests
Merged-In: Ic45add1eaed0bd30788544b1b5bfd0f39a85a364
Change-Id: Ic45add1eaed0bd30788544b1b5bfd0f39a85a364
parent 5abdc91e

tests/unit/AndroidManifest.xml

+0 −1
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
    <!-- TODO: many of the below permissions seem to be unused, remove them. -->

    <uses-permission android:name="android.permission.WRITE_SETTINGS" />

    <uses-permission android:name="android.permission.READ_PHONE_STATE" />

    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />

    <uses-permission android:name="android.permission.BROADCAST_STICKY" />

    <uses-permission android:name="android.permission.MANAGE_APP_TOKENS" />

    <uses-permission android:name="android.permission.WAKE_LOCK" />