Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • A android_packages_modules_DnsResolver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • e
  • os
  • android_packages_modules_DnsResolver
  • Merge requests
  • !4

shouldBlockRequest: Don't block if socket connect fails

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rohit requested to merge 145devices-r-sockfail_unblock into v1-r May 20, 2022
  • Overview 2
  • Commits 1
  • Changes 1

Description

shouldBlockRequest: Don't block if socket connect fails

Issue(s)

https://gitlab.e.foundation/e/devices/backlog/-/issues/145

Test environment

  • Set CI branch to feature-branch-for-dev-stable
  • Make a build with the following parameters:
    • DEVICES: FP4 emerald
    • BRANCH_NAME: v1-r
    • FEATURE_BRANCH: 145devices-r-sockfail_unblock
    • RELEASE_TYPE: stable

Pipeline:

  • FP4: https://gitlab.e.foundation/e/priv/os/build/-/jobs/309557
  • emerald: https://gitlab.e.foundation/e/priv/os/build/-/jobs/309572

Test procedures

  • Install build
  • Connect to WiFi
  • On reboot, WiFi connects and is connected to the internet

Technical details

  • See commit message

Check list

  • Self review
  • Test procedure explained
  • Tested on fresh install
  • Tested applied as an update
  • License
  • Internal documentation
  • User documentation
Edited May 23, 2022 by Rohit
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 145devices-r-sockfail_unblock